Review Request 120194: Ported Dolphin away from KStandardDirs

[Emmanuel Pescosta]

> On Sept. 14, 2014, 10:02 p.m., Hrvoje Senjan wrote:
> > dolphin/src/settings/services/servicessettingspage.cpp, line 198
> > <https://git.reviewboard.kde.org/r/120194/diff/1/?file=312106#file312106line198>
> >
> >     this is usually $prefix/share/kservices5
> 
> Emmanuel Pescosta wrote:
>     According to the porting notes it is "kde5/services/". 
>     
>     KStandardDirs::locate("services", "foo.desktop") -> QStandardPaths::locate(QStandardPaths::GenericDataLocation, "kde5/services/foo.desktop")
> 
> Hrvoje Senjan wrote:
>     hm, then the notes are outdated in this regard, see commit 13319db448976beeb2a879612f36e9cb1b37c4ea in e-c-m

The porting script (convert-kstandarddirs.pl) also follows the porting notes.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120194/#review66494
-----------------------------------------------------------


On Sept. 14, 2014, 11:27 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120194/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2014, 11:27 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> * Ported Dolphin away from KStandardDirs
> * removed unused mirroredDirectory method
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.cpp e74adca 
>   dolphin/src/dolphinmainwindow.cpp 5e5eeb0 
>   dolphin/src/panels/places/placesitemmodel.cpp 8eb79a8 
>   dolphin/src/settings/services/servicessettingspage.cpp 78a865d 
>   dolphin/src/settings/viewpropertiesdialog.cpp 41a39f2 
>   dolphin/src/views/viewproperties.h 69b507f 
>   dolphin/src/views/viewproperties.cpp bcea062 
> 
> Diff: https://git.reviewboard.kde.org/r/120194/diff/
> 
> 
> Testing
> -------
> 
> Works. View mode settings of read only folders are stored properly.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140915/8e35aee4/attachment.htm>