Review Request 120137: Add new KIO job that let's you get a drive's size (smb or local for now), part 3/3

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120137/#review66235
-----------------------------------------------------------

Ship it!


Thanks for working on this (again)! 
The Dolphin side looks good.

Should I push it for you when your KIO patches are in?

- Emmanuel Pescosta


On Sept. 11, 2014, 11:42 a.m., Mathias Tillman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120137/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 11:42 a.m.)
> 
> 
> Review request for Dolphin and David Faure.
> 
> 
> Bugs: 245226
>     http://bugs.kde.org/show_bug.cgi?id=245226
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> This patch adds support for the new driveSize job used for the status bar space info.
> 
> This is a follow up to : https://git.reviewboard.kde.org/r/114956/ and https://git.reviewboard.kde.org/r/114957/.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/statusbar/mountpointobserver.h ac5f8ecc37391ff589d2f26e459e8ab625084b6a 
>   dolphin/src/statusbar/mountpointobserver.cpp 4a23be6b621320f086464c1e7cee04854a78392f 
>   dolphin/src/statusbar/mountpointobservercache.h 425000645b7eb4b90aafca6fef8d62f3292e53a4 
>   dolphin/src/statusbar/spaceinfoobserver.cpp 9125a9308a51fc8f406f12d931f7380e06e8f5e9 
>   dolphin/src/statusbar/statusbarspaceinfo.cpp ea8b4704c02f6a9ed9e14d15882081fadbefffe4 
>   dolphin/src/statusbar/spaceinfoobserver.h d2fb6ebf31ad88ae7b233ebffb00c1ef48db4359 
>   dolphin/src/statusbar/mountpointobservercache.cpp aff0c8e2f051737ab9e8544107e3f12eb3c7a665 
> 
> Diff: https://git.reviewboard.kde.org/r/120137/diff/
> 
> 
> Testing
> -------
> 
> I've tried browsing around normally in dolphin, both in local drives and in samba shares.
> 
> 
> Thanks,
> 
> Mathias Tillman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140911/90e92fc3/attachment.htm>