Review Request 119986: Dolphin: Rename "Recently Accessed" to "Recently Modified"

[kdeuser 56]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119986/
-----------------------------------------------------------

(Updated Sept. 2, 2014, 9:23 a.m.)


Review request for Dolphin, Frank Reininghaus and Vishesh Handa.


Changes
-------

resolved issues (reason was I forgot the "g" in the sed commands, and because I used sed, I forgot about the indentation too) and dropped frameworks diff.


Bugs: 304854
    http://bugs.kde.org/show_bug.cgi?id=304854


Repository: kde-baseapps


Description
-------

In dolphin the Section that leads you to timeline claims to show "Recently Accessed", which is not true, it shows "Recently Modified". I think this should be corrected, both in the ui and in the code, since this is very misleading.

Even if it was planned for the future to offer "Recently Accessed" this should be separated anyway from "Recently Modified" since, for a user "Recently Modified" is without any doubt the more important information and should not get lost as a subset of "Recently Accessed".

"Recently Accessed" would anyway cause a lot of trouble with the implementation since a lot of people have disabled atime, so it would not be reliable without a custom daemon watching files for access times.

The diff for the frameworks branch is attatched.


Diffs (updated)
-----

  doc/dolphin/index.docbook 5fe85f5 
  dolphin/src/panels/places/placesitem.h 297f12d 
  dolphin/src/panels/places/placesitem.cpp 539b926 
  dolphin/src/panels/places/placesitemmodel.cpp dc2b95c 
  dolphin/src/panels/places/placespanel.cpp f19fa1e 

Diff: https://git.reviewboard.kde.org/r/119986/diff/


Testing
-------

compiled and tested


Thanks,

kdeuser 56

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140902/e6d1b203/attachment.htm>