Review Request 119986: Dolphin: Rename "Recently Accessed" to "Recently Modified"

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119986/#review65655
-----------------------------------------------------------



dolphin/src/panels/places/placesitem.cpp
<https://git.reviewboard.kde.org/r/119986/#comment45883>

    Please adjusted the indentation



dolphin/src/panels/places/placesitem.cpp
<https://git.reviewboard.kde.org/r/119986/#comment45884>

    Please adjusted the indentation



dolphin/src/panels/places/placesitem.cpp
<https://git.reviewboard.kde.org/r/119986/#comment45885>

    "Recently Accessed" should be "Recently Saved", see Frank's comment.



dolphin/src/panels/places/placesitemmodel.cpp
<https://git.reviewboard.kde.org/r/119986/#comment45886>

    Please adjusted the indentation



dolphin/src/panels/places/placesitemmodel.cpp
<https://git.reviewboard.kde.org/r/119986/#comment45887>

    Please adjusted the indentation


- Emmanuel Pescosta


On Aug. 29, 2014, 7 p.m., kdeuser 56 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119986/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2014, 7 p.m.)
> 
> 
> Review request for Dolphin, Frank Reininghaus and Vishesh Handa.
> 
> 
> Bugs: 304854
>     http://bugs.kde.org/show_bug.cgi?id=304854
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> In dolphin the Section that leads you to timeline claims to show "Recently Accessed", which is not true, it shows "Recently Modified". I think this should be corrected, both in the ui and in the code, since this is very misleading.
> 
> Even if it was planned for the future to offer "Recently Accessed" this should be separated anyway from "Recently Modified" since, for a user "Recently Modified" is without any doubt the more important information and should not get lost as a subset of "Recently Accessed".
> 
> "Recently Accessed" would anyway cause a lot of trouble with the implementation since a lot of people have disabled atime, so it would not be reliable without a custom daemon watching files for access times.
> 
> The diff for the frameworks branch is attatched.
> 
> 
> Diffs
> -----
> 
>   doc/dolphin/index.docbook 5fe85f5 
>   dolphin/src/panels/places/placesitem.h 297f12d 
>   dolphin/src/panels/places/placesitem.cpp 539b926 
>   dolphin/src/panels/places/placesitemmodel.cpp dc2b95c 
>   dolphin/src/panels/places/placespanel.cpp f19fa1e 
> 
> Diff: https://git.reviewboard.kde.org/r/119986/diff/
> 
> 
> Testing
> -------
> 
> compiled and tested
> 
> 
> File Attachments
> ----------------
> 
> frameworks.diff
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/29/cc4b3a71-b2fc-4c2c-9109-355521b15019__frameworks-rev1.diff
> 
> 
> Thanks,
> 
> kdeuser 56
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140901/92cf9fd9/attachment.htm>