[KDE Usability] Review Request 120171: Add option to allow execution as well as opening of scripts and desktop files

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120171/#review69324
-----------------------------------------------------------



dolphin/src/settings/general/confirmationssettingspage.cpp
<https://git.reviewboard.kde.org/r/120171/#comment48465>

    Nitpick: One space too much



dolphin/src/settings/general/confirmationssettingspage.cpp
<https://git.reviewboard.kde.org/r/120171/#comment48467>

    The m_confirmScriptExecution check isn't needed, it is guaranteed that the pointer is valid. Maybe you mean m_confirmScriptExection->isChecked() instead?
    
    Can you please move the scriptExecutionGroup below the confirmationGroup sync?
    
    And you need to sync the scriptExecutionGroup as well.



dolphin/src/settings/general/confirmationssettingspage.cpp
<https://git.reviewboard.kde.org/r/120171/#comment48468>

    I think we should set it to alwaysAsk instead of deleting it, makes it more obvious.



dolphin/src/settings/general/confirmationssettingspage.cpp
<https://git.reviewboard.kde.org/r/120171/#comment48469>

    const


- Emmanuel Pescosta


On Oct. 28, 2014, 3:38 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120171/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 3:38 p.m.)
> 
> 
> Review request for Dolphin, KDE Usability and David Faure.
> 
> 
> Bugs: 275405
>     http://bugs.kde.org/show_bug.cgi?id=275405
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> This patch allows the user to execute (in background, within the embedded terminal, external terminal) or open an executable file (scripts, desktop files...). When the user clicks on an executable file, a [dialog](https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/0fa53887-666f-4121-9ec6-9f323d633d03__dialog.png) pops up which contains options to either open it or execute it. Clicking on execute runs the program in the background (dolphin's current behaviour).
> 
> The [settings dialog](https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/cd4d14d3-dd82-4c2c-8c0a-c2a428c78903__settings.png) has further options to fine-tune how the file is executed. The program can either be executed in the background or inside the embedded konsole or in an external terminal.
> 
> In case there is a process already running in the embedded terminal, with [user's permission](https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/c5d7843a-099a-43d4-a2e1-6ce429623866__replace.png) it will be terminated and the selected program will be started.
> 
> 
> See also:
> https://git.reviewboard.kde.org/r/118939/
> 
> 
> Diffs
> -----
> 
>   dolphin/src/settings/general/confirmationssettingspage.h 45f0be1 
>   dolphin/src/settings/general/confirmationssettingspage.cpp b04ab61 
> 
> Diff: https://git.reviewboard.kde.org/r/120171/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/0fa53887-666f-4121-9ec6-9f323d633d03__dialog.png
> settings
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/cd4d14d3-dd82-4c2c-8c0a-c2a428c78903__settings.png
> Replace current program
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/c5d7843a-099a-43d4-a2e1-6ce429623866__replace.png
> CheckBox (revision 6)
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/10/28/aad92b34-dd4f-4d68-abd4-9a21eb0399ef__script_exec.png
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141028/99e63188/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability