Review Request 120745: Fix video previews in Dolphin

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120745/#review68979
-----------------------------------------------------------



dolphin/src/panels/information/phononwidget.cpp
<https://git.reviewboard.kde.org/r/120745/#comment48243>

    Can you please move it out of if(m_media){}, like audio output.



dolphin/src/panels/information/phononwidget.cpp
<https://git.reviewboard.kde.org/r/120745/#comment48244>

    We don't want to show it instantly, because we don't know if we have a video or not.
    
    slotHasVideoChanged will make it visible once we know that the media is a video.



dolphin/src/panels/information/phononwidget.cpp
<https://git.reviewboard.kde.org/r/120745/#comment48245>

    You can apply the video size immediately after creating a new video player instance.
    
    All further size changes are applied by PhononWidget::applyVideoSize()


- Emmanuel Pescosta


On Oct. 23, 2014, 12:11 p.m., Andrey Bondrov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120745/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 12:11 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 334924, 337033 and 337107
>     http://bugs.kde.org/show_bug.cgi?id=334924
>     http://bugs.kde.org/show_bug.cgi?id=337033
>     http://bugs.kde.org/show_bug.cgi?id=337107
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Fix video previews in Dolphin
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/information/phononwidget.cpp a36ada1 
> 
> Diff: https://git.reviewboard.kde.org/r/120745/diff/
> 
> 
> Testing
> -------
> 
> Emmanuel Pescosta confirmed that this patch fixes #334924, #337033 and #337107. See https://bugs.kde.org/show_bug.cgi?id=334924#c8
> 
> 
> Thanks,
> 
> Andrey Bondrov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141023/052caf70/attachment.htm>