Review Request 120726: Connect to the Konsole part's currentDirectoryChanged(QString) only after the shell has been set up completely

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120726/#review68956
-----------------------------------------------------------

Ship it!


Thanks for the patch! 
It works for me too, no regression found so far :)

I can't reproduce the crash, but I think that your patch will definitely fix it ;)

- Emmanuel Pescosta


On Oct. 22, 2014, 7:02 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120726/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 7:02 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 339502 and 340233
>     http://bugs.kde.org/show_bug.cgi?id=339502
>     http://bugs.kde.org/show_bug.cgi?id=340233
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> We listen to Konsole's currentDirectoryChanged(QString) signal to ensure that the view URL is synced to the Terminal Panel if the user enters "cd" commands. Currently, the connection is made before calling
> 
>         m_terminal->showShellInDir(url().toLocalFile());
>         
> and
> 
>         changeDir(url());
>         
> The problem is that these functions may trigger the emission of the signal, but because that is not the result of a "cd" command entered by the user, we should not react to it.
> 
> Moving the connection further down in the function fixes https://bugs.kde.org/show_bug.cgi?id=340233 for me, and it makes crashes with backtraces like the one in https://bugs.kde.org/show_bug.cgi?id=339502 impossible.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/terminal/terminalpanel.cpp bfd3002 
> 
> Diff: https://git.reviewboard.kde.org/r/120726/diff/
> 
> 
> Testing
> -------
> 
> Fixes https://bugs.kde.org/show_bug.cgi?id=340233 for me. No regressions found so far.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141023/1c9227a2/attachment.htm>