Review Request 120695: Dolphin: port to KIO::pasteInfoText().

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120695/#review68841
-----------------------------------------------------------

Ship it!


Thanks for the patch!

I think it should be precise about the source because the "from" is 
in most cases much more interesting (the user can see the 
destination anyway), so the change is ok!

Btw. the treeview context menu can only paste to folders, but it 
never used "paste to folder", so I think this change is also 
good in terms of consistency ;)

- Emmanuel Pescosta


On Oct. 21, 2014, 9:28 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120695/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 9:28 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> I'm just not 100% sure about the DolphinContextMenu::createPasteAction change,
> since it used to be precise about destination ("Paste To Folder"),
> while now it's precise about the source (what to paste).
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.cpp f597d52e320af42aae784c190eb61bbee2e600f2 
>   dolphin/src/panels/folders/treeviewcontextmenu.cpp 330e185603ae2c0c8c1c006ef3cecd500feeef8a 
>   dolphin/src/views/dolphinview.cpp 0b3209aee7af48353647dfb0ee9671d6681ce2d6 
> 
> Diff: https://git.reviewboard.kde.org/r/120695/diff/
> 
> 
> Testing
> -------
> 
> compiles.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141021/f4b3bc13/attachment.htm>