Review Request 120582: Port Dolphin to the new Baloo APIs

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120582/#review68395
-----------------------------------------------------------

Ship it!


Thanks, looks good!

- Emmanuel Pescosta


On Oct. 14, 2014, 3:42 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120582/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 3:42 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> This is just a simple port.
> 
> The new APIs are still in a custom branch in Baloo, but I would like to avoid breaking the build when I do merge it into master.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt 3ad68c7 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e9652e3 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp 5c212a9 
>   dolphin/src/kitemviews/private/kbaloorolesprovider.cpp 5096ef0 
>   dolphin/src/search/dolphinsearchbox.cpp 0fb1e41 
> 
> Diff: https://git.reviewboard.kde.org/r/120582/diff/
> 
> 
> Testing
> -------
> 
> Manually tested viewing of tags and image size.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141014/a5828e77/attachment.htm>