Review Request 121293: Fix bug 341411 - Going Up breaks titlebar

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121293/#review71109
-----------------------------------------------------------


Arjun, what do you think about merging DolphinTabWidget::tabName and DolphinMainWindow::setUrlAsCaption?

Host and scheme for non local urls are also interesting for tabs in my opinion and everything else is basically the same ;)

- Emmanuel Pescosta


On Nov. 30, 2014, 11:33 a.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121293/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2014, 11:33 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 341411
>     http://bugs.kde.org/show_bug.cgi?id=341411
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> From Qt documentation:
> >Note that, if this QUrl object is given a path ending in a slash, the name of the file is considered empty.
> 
> The trailing slash needs to be removed before `fileName()` is called.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 81aa1e8 
> 
> Diff: https://git.reviewboard.kde.org/r/121293/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141130/2563fa59/attachment.htm>