Review Request 121293: Fix bug 341411 - Going Up breaks titlebar
Kai Uwe Broulik
kde at privat.broulik.de
Sun Nov 30 10:47:12 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121293/#review71106
-----------------------------------------------------------
Thanks!
I can confirm that this fixes the issue for me.
dolphin/src/dolphinmainwindow.cpp
<https://git.reviewboard.kde.org/r/121293/#comment49670>
Rather QLatin1Char('/') ?
- Kai Uwe Broulik
On Nov. 30, 2014, 10:33 vorm., Arjun AK wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121293/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2014, 10:33 vorm.)
>
>
> Review request for Dolphin.
>
>
> Bugs: 341411
> http://bugs.kde.org/show_bug.cgi?id=341411
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> From Qt documentation:
> >Note that, if this QUrl object is given a path ending in a slash, the name of the file is considered empty.
>
> The trailing slash needs to be removed before `fileName()` is called.
>
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.cpp 81aa1e8
>
> Diff: https://git.reviewboard.kde.org/r/121293/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun AK
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141130/e73726e0/attachment.htm>
More information about the kfm-devel
mailing list