Review Request 121087: Use deleteLater() to delete the selection toggle in KItemListWidget::slotHoverAnimationFinished()
Frank Reininghaus
frank78ac at googlemail.com
Sun Nov 9 17:11:27 GMT 2014
> On Nov. 9, 2014, 4:57 nachm., Emmanuel Pescosta wrote:
> > Ship It!
Thanks for the extremely quick response :-)
- Frank
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121087/#review70117
-----------------------------------------------------------
On Nov. 9, 2014, 4:55 nachm., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121087/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2014, 4:55 nachm.)
>
>
> Review request for Dolphin.
>
>
> Bugs: 334785
> http://bugs.kde.org/show_bug.cgi?id=334785
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> This patch should make a crash with a backtrace as provided in the bug report impossible. I'm not sure if this would really prevent the crash - it looks like the actual cause of the problem could be in QGraphicsView or anywhere else. But I'm pretty sure that this change doesn't make anything worse.
>
>
> Diffs
> -----
>
> dolphin/src/kitemviews/kitemlistwidget.cpp e7d2951
>
> Diff: https://git.reviewboard.kde.org/r/121087/diff/
>
>
> Testing
> -------
>
> Hovering and un-hovering icons and selection toggles works as before.
>
>
> Thanks,
>
> Frank Reininghaus
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141109/5afbf64d/attachment.htm>
More information about the kfm-devel
mailing list