Review Request 120986: fix Bug 340470 - Unable to filter for opening square brackets: [

[Frank Reininghaus]

> On Nov. 4, 2014, 3:03 nachm., Emmanuel Pescosta wrote:
> > dolphin/src/kitemviews/private/kfileitemmodelfilter.cpp, lines 46-62
> > <https://git.reviewboard.kde.org/r/120986/diff/1/?file=325322#file325322line46>
> >
> >     Maybe we can make this code easier by always using the m_regExp to check if the pattern is a valid regexp or not.
> >     
> >     All this code could be replaced by:
> >     
> >     if (!m_regExp) {
> >        ...
> >     }
> >     m_regExp->setPattern(filter);
> >     m_useRegExp = m_regExp->isValid();
> >     
> >     What do you think?
> 
> Arjun AK wrote:
>     That won't work because even "foo" is a valid regexp

Do we really use regular expression matching at the moment? AFAIK, there is only wildcard matching (i.e., '?' matches a single character and an asterisk any string). I don't know why the check if the filter pattern contains '[' is done at all.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120986/#review69820
-----------------------------------------------------------


On Nov. 4, 2014, 2:28 nachm., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120986/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 2:28 nachm.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> We need to make sure input is a valid regexp before enabling regexp filter mode.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/private/kfileitemmodelfilter.cpp 2e320f2 
> 
> Diff: https://git.reviewboard.kde.org/r/120986/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141104/3b9b591f/attachment.htm>