Review Request 120986: fix Bug 340470 - Unable to filter for opening square brackets: [

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120986/#review69820
-----------------------------------------------------------



dolphin/src/kitemviews/private/kfileitemmodelfilter.cpp
<https://git.reviewboard.kde.org/r/120986/#comment48864>

    Maybe we can make this code easier by always using the m_regExp to check if the pattern is a valid regexp or not.
    
    All this code could be replaced by:
    
    if (!m_regExp) {
       ...
    }
    m_regExp->setPattern(filter);
    m_useRegExp = m_regExp->isValid();
    
    What do you think?


- Emmanuel Pescosta


On Nov. 4, 2014, 3:28 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120986/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 3:28 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> We need to make sure input is a valid regexp before enabling regexp filter mode.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/private/kfileitemmodelfilter.cpp 2e320f2 
> 
> Diff: https://git.reviewboard.kde.org/r/120986/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141104/a9de2717/attachment.htm>