Review Request 120941: Fix unit test failures that result from incorrect KUrl -> QUrl porting

Frank Reininghaus frank78ac at googlemail.com
Sun Nov 2 06:01:25 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120941/
-----------------------------------------------------------

Review request for Dolphin.


Repository: kde-baseapps


Description
-------

https://git.reviewboard.kde.org/r/120650/ introduced a couple of unit test failures by replacing KUrl functions with QUrl functions which are not semantically equivalent. This patch fixes these.


Diffs
-----

  dolphin/src/tests/kfileitemmodeltest.cpp 758699d 

Diff: https://git.reviewboard.kde.org/r/120941/diff/


Testing
-------

kfileitemmodeltest is down from 6 failures to 1 - the last one is there since the frameworks port was started. I'll try to have a look at that one soon.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141102/d477ca5f/attachment.htm>


More information about the kfm-devel mailing list