Review Request 118395: Selection toggle hover effect

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118395/#review58815
-----------------------------------------------------------


Thanks for the patch.

Maybe I should have tried the last Dolphin 1.x version before I made that remark or said "look at Dolphin 1.x before starting to work on this" :-( Sorry that I did not do it.

I tried it now, and it turns out that my memory was incorrect: the fading animation was not for hovering the toggle itself, but for the appearance of the toggle when hovering the corresponding item in the view. The code can be found at

http://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=d602600c58754a3211056c2fc95d2c588636c5a3&hb=35e3a9a44a32ccd46a138ee397de405318219803&f=dolphin%2Fsrc%2Fviews%2Fselectiontoggle.cpp

Now I don't really know which of the animations makes more sense, or if they make sense at all. I tried your patch, and it works fine, but the change of the selection toggle now looks quite subtle. Maybe it's too easy to miss that the toggle is hovered now? I really don't know.

Thinking about it again, maybe the animation that fades the selection toggle in when hovering the item probably does make some sense. The hover effect of the icon itself is animated after all, and now when I hover icons and I focus my attention on the toggle, it looks weird that it appears all of a sudden, whereas the effect of the icon itself is animated nicely.

But I'm not an expert for these design-related things. If anyone has good arguments for or against these animations, please let us know!

- Frank Reininghaus


On May 29, 2014, 1:46 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118395/
> -----------------------------------------------------------
> 
> (Updated May 29, 2014, 1:46 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Add a fade-in/-out effect to KItemListSelectionToggle as proposed in review request 118320 by Frank.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 758dc63 
>   dolphin/src/kitemviews/private/kitemlistselectiontoggle.cpp accbe51 
> 
> Diff: https://git.reviewboard.kde.org/r/118395/diff/
> 
> 
> Testing
> -------
> 
> Works fine.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140530/8b66383d/attachment.htm>