Review Request 118320: Fix selection toggle hovering

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118320/#review58468
-----------------------------------------------------------

Ship it!


Thanks for the patch! Looks good and works nicely here.

I guess it might be even better to use a fade-in/fade-out animation for the toggle (I think we had something like that in Dolphin 1.x), but this is just something to keep in mind for the future (4.14 maybe).

- Frank Reininghaus


On May 25, 2014, 5:04 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118320/
> -----------------------------------------------------------
> 
> (Updated May 25, 2014, 5:04 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 299328
>     http://bugs.kde.org/show_bug.cgi?id=299328
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Use "selectionToggleRect().contains(pos)" instead of "m_selectionToggle->contains(pos)" in 
> KItemListWidget::setHoverPosition(const QPointF& pos).
> 
> This wrong check was accidentally introduced by commit 24326d447358f0dbfc18963743207d4a3d4f1c9e 
> 
> I have marked this bug as Junior Job some time ago, but nobody stepped up
> so far. I have decided to fix it now, so that our users don't suffer from this 
> problem anymore in Dolphin 4.13.2.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistwidget.cpp 44754a6 
> 
> Diff: https://git.reviewboard.kde.org/r/118320/diff/
> 
> 
> Testing
> -------
> 
> Works fine for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140526/376cee48/attachment.htm>