Review Request 117748: rename many files, with change, add or delete the extension

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117748/#review57178
-----------------------------------------------------------


First of all, thanks for your patch, and sorry for the late response - somehow, I must have missed the first notification mail.

Please always provide before/after screenshots in review requests which change anything in the GUI.

Before we discuss the code, the following questions should be addressed:


1. Considering that all the new codes which are shown in the dialog might confuse users who do not need them: is the feature useful enough for enough users to justify this?

I see that including this advanced renaming feature in Dolphin directly instead of using a tool like KRename might be more convenient for users who use such a thing frequently. However, a good alternative might be to put this feature into a context menu plugin, which could be installed by anyone who needs it, and which would not harm the usability for users who don't.


2. I'm not sure if the design of the dialog is optimal. Users who are used to the simple "add an ascending number" rename mechanism might be overwhelmed by all the text explaining the options.


I suggest that you add the usability team to this review request (after adding before/after screenshots). They have provided great advice for dialog design in the past, see, e.g., http://sessellift.wordpress.com/2014/05/01/the-little-things/ and they might also help to judge the question "do we need this feature in the default file manager or not".

I see two ways how your approach could be modified, but there might be more:

(a) Put the advanced renaming feature into a context menu plugin (such that there would be an entry like "Rename (advanced)..." in the context menu, which would then open this dialog, for users who install and enable the plugin).

(b) Keep the existing dialog as it is, and only show the advanced options if the user clicks an "Advanced options..." button.

- Frank Reininghaus


On May 2, 2014, 9:16 p.m., Mario Scheel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117748/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 9:16 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> rename many files, with change, add or delete the extension.
> 
> Example:
> You have an directory with these files:
> img_123.JPG
> img_234.JPG
> img_345.JPG
> 
> You cann now select these files and type "%f.jpg". These changes the extensions to jpg.
> 
> Or a other example:
> directory:
> importand_app.exe.txt
> importand_app1.dll.txt
> importand_app2.dll.txt
> 
> These are files vom an email attachment.
> You can select the files and type "%f".
> This deletes the exensions .txt and your directory looks like:
> importand_app.exe
> importand_app1.dll
> importand_app2.dll
> 
> These variables are defined:
> %n an fortlaufende number
> %f the filename without extension
> %e the extension
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/renamedialog.h 29ef8bdf131f7608bb87437679ac8811e5669c71 
>   dolphin/src/views/renamedialog.cpp 5c0ae61261a4b71da987a3b180e314a61973aabd 
> 
> Diff: https://git.reviewboard.kde.org/r/117748/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario Scheel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140503/0a1a530e/attachment.htm>