Review Request 111968: Make newly opened search tabs close- and editable

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111968/#review54438
-----------------------------------------------------------

Ship it!


I see that you haven't pushed this yet. Maybe it's because you haven't found the time, but just to prevent any misunderstandings, I'll say "Ship It" again. The last version looked fine to me, and the new one only seems to contain minor modifications (unfortunately, it's hard to see what exactly changed in a patch in ReviewBoard, because the "diff of the diffs" also shows any other changes that happened in the mean time).

I'm still not entirely sure about the best name for the from* functions, but as I said, it's a minor issue and might be a matter of taste. Thanks again for your work on this.

- Frank Reininghaus


On March 25, 2014, 10:35 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/111968/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 10:35 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 311950
>     http://bugs.kde.org/show_bug.cgi?id=311950
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> When you open a new tab while the search mode is enabled, the newly opened 
> tab also starts the same search (Because new tab is opened with the current 
> view url), but the search box is in read-only mode. 
> So you cannot close the search bar nor edit the search text.
> 
> This patch fixes this by parsing the search url. The value of the "search"
> parameter is used as search text and the value of the "url" parameter is used 
> for the search path ("root" folder for the search when "Search from here" mode 
> is enabled).
> 
> In case of Baloo search urls, we use Baloo::Query::fromSearchUrl.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.cpp 768fd5e 
>   dolphin/src/search/dolphinfacetswidget.h 1fd1683 
>   dolphin/src/search/dolphinfacetswidget.cpp 3824eb9 
>   dolphin/src/search/dolphinsearchbox.h 6dc09f1 
>   dolphin/src/search/dolphinsearchbox.cpp 0a70566 
> 
> Diff: https://git.reviewboard.kde.org/r/111968/diff/
> 
> 
> Testing
> -------
> 
> 1. Start a search (e.g. "kde") in folder $HOME/Downloads
> 2. Open a new tab
> 3. Edit the search mode should work
> 4. Close the search
> 5. The view from the newly opened tab should open $HOME/Downloads
> 
> All five points works for me.
> 
> Tested with Baloo 4.13 Beta1
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140328/315b2da0/attachment.htm>