Review Request 116837: Add the Baloo::Term to the Baloo:Query in DolphinSearchBox::balooUrlForSearching().

Frank Reininghaus frank78ac at googlemail.com
Sun Mar 16 17:19:25 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116837/#review53076
-----------------------------------------------------------


Thanks for the patch - looks reasonable to me!

Unless Vishesh has any objections (he is more familiar with this code than I am), this should go in. I'll try to have a closer look at https://git.reviewboard.kde.org/r/111968/ soon.

- Frank Reininghaus


On March 16, 2014, 4:21 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116837/
> -----------------------------------------------------------
> 
> (Updated March 16, 2014, 4:21 p.m.)
> 
> 
> Review request for Dolphin and Vishesh Handa.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Add the Baloo::Term to the Baloo:Query in DolphinSearchBox::balooUrlForSearching().
> 
> 
> Diffs
> -----
> 
>   dolphin/src/search/dolphinsearchbox.cpp c178c43 
> 
> Diff: https://git.reviewboard.kde.org/r/116837/diff/
> 
> 
> Testing
> -------
> 
> Rating works now.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140316/fa544fea/attachment.htm>


More information about the kfm-devel mailing list