Review Request 111968: Make newly opened search tabs close- and editable

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111968/
-----------------------------------------------------------

(Updated March 16, 2014, 5:24 p.m.)


Review request for Dolphin.


Changes
-------

Baloo case fixed ;)

Removed everything related to read only mode in DolphinSearchBox, not needed
anymore.

To properly test this patch, you need this patch 116837 too.


Bugs: 311950
    http://bugs.kde.org/show_bug.cgi?id=311950


Repository: kde-baseapps


Description (updated)
-------

When you open a new tab while the search mode is enabled, the newly opened 
tab also starts the same search (Because new tab is opened with the current 
view url), but the search box is in read-only mode. 
So you cannot close the search bar nor edit the search text.

This patch fixes this by parsing the search url. The value of the "search"
parameter is used as search text and the value of the "url" parameter is used 
for the search path ("root" folder for the search when "Search from here" mode 
is enabled).

In case of Baloo search urls, we use Baloo::Query::fromSearchUrl.


Diffs (updated)
-----

  dolphin/src/dolphinviewcontainer.cpp 768fd5e 
  dolphin/src/search/dolphinfacetswidget.h 526fe1c 
  dolphin/src/search/dolphinfacetswidget.cpp b7315a0 
  dolphin/src/search/dolphinsearchbox.h 6dc09f1 
  dolphin/src/search/dolphinsearchbox.cpp c178c43 

Diff: https://git.reviewboard.kde.org/r/111968/diff/


Testing
-------

1. Start a search (e.g. "kde") in folder $HOME/Downloads
2. Open a new tab
3. Edit the search mode should work
4. Close the search
5. The view from the newly opened tab should open $HOME/Downloads

All five points works for me.

Btw:
Please test it with nepomuk searches, because nepomuk doesn't work for me (Don't know why?! - Maybe smth. is wrong in the arch/kde-unstable repo)


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140316/d52b4ba9/attachment.htm>