Review Request 108693: Places appears twice when unlocking dock widgets.

Daniel Kreuter daniel.kreuter85 at gmail.com
Thu Mar 13 20:12:43 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/108693/
-----------------------------------------------------------

(Updated March 13, 2014, 8:12 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin and Frank Reininghaus.


Bugs: 301405
    http://bugs.kde.org/show_bug.cgi?id=301405


Repository: kde-baseapps


Description
-------

When unlocking the dock widgets, the places text will appear twice.
I removed all titles of the dock widgets and replaced them with an empty string (removed all for consistency).
In my opinion, this is the easiest solution I could find so far (I made another proposals on the ML a few hours ago).


Diffs
-----

  dolphin/src/dolphinmainwindow.cpp 8ed31de 

Diff: https://git.reviewboard.kde.org/r/108693/diff/


Testing
-------

Open dolphin and unlock each dock (places, folders, information and terminal). There should only be the two buttons in the title bar, but no title, Drag & Drop should work just like before.


Thanks,

Daniel Kreuter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140313/eeb9cd83/attachment.htm>


More information about the kfm-devel mailing list