Review Request 116121: Fix Bug 326210 - Dolphin unnecessarily truncates names of soft links in compact mode

[Emmanuel Pescosta]

> On March 5, 2014, 8:36 a.m., Frank Reininghaus wrote:
> > Thanks for the patch, and sorry for the late response. The approach looks good, and I think that this patch will solve fix both bugs (see my comments in the bug reports).
> > 
> > However, I'm wondering if we can avoid calling "view->model()->data(index).value("isLink")" in KStandardItemListWidgetInformant::itemIsLink(). Calling "data" for every item in the model essentially means that we revert https://git.reviewboard.kde.org/r/112725/ , such that this fix would increase the memory usage considerably.
> > 
> > Since the "isLink" property is only ever used in KFileItemListView/Widget: maybe just make
> > 
> > KStandardItemListWidgetInformant::itemIsLink(int index, const KItemListView* view)
> > 
> > return "false"? The function
> > 
> > KFileItemListWidgetInformant::itemIsLink(int index, const KItemListView* view)
> > 
> > does the right thing.
> > 
> >

> maybe just make KStandardItemListWidgetInformant::itemIsLink(int index, const KItemListView* view) return "false"?
Great idea, I'll change it ;)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116121/#review52009
-----------------------------------------------------------


On Feb. 27, 2014, 3:11 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116121/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 3:11 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 326210
>     http://bugs.kde.org/show_bug.cgi?id=326210
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Fix Bug 326210 - Dolphin unnecessarily truncates names of soft links in compact mode
> 
> Maybe this patch fixes also bug 310592, but I can't reproduce this bug, so I can't test if it works.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemlistwidget.h 1d7bc7f 
>   dolphin/src/kitemviews/kfileitemlistwidget.cpp 688a4da 
>   dolphin/src/kitemviews/kstandarditemlistwidget.h ca198c3 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp 9f7b269 
> 
> Diff: https://git.reviewboard.kde.org/r/116121/diff/
> 
> 
> Testing
> -------
> 
> Bug 326210 is fixed for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140305/fdd98d98/attachment.htm>