Review Request 116562: Remove some unused functions
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Mon Mar 3 21:03:00 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116562/#review51822
-----------------------------------------------------------
Ship it!
Ship It!
- Emmanuel Pescosta
On March 3, 2014, 11:03 a.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116562/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 11:03 a.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> When thinking about the "hover" issues that have been discussed recently, I found some functions in DolphinView, showHoverInformation() and clearHoverInformation(), which seem to be unused.
>
> Another unused function is in the rename dialog.
>
>
> Diffs
> -----
>
> dolphin/src/views/dolphinview.h 3731464
> dolphin/src/views/dolphinview.cpp 2769d67
> dolphin/src/views/renamedialog.cpp d8dbd77
>
> Diff: https://git.reviewboard.kde.org/r/116562/diff/
>
>
> Testing
> -------
>
> Dolphin still compiles, and the status bar info for hovered items is still shown correctly.
>
>
> Thanks,
>
> Frank Reininghaus
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140303/0bb52aaa/attachment.htm>
More information about the kfm-devel
mailing list