Review Request 116028: Add a hover effect for the selection toggle.

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116028/#review51747
-----------------------------------------------------------

Ship it!


Thanks for the explanation. I would still prefer a solution that makes use of QGraphicsView's hover event handling, but I see that this may require much more work, and I'm also not extremely motivated to dig deep into the QGraphicsView code and figure out how it could be done.

So please push it to KDE/4.13 (I would not add the isHovered() function that is never called AFAICS though). Thanks for your work on this!


dolphin/src/kitemviews/private/kitemlistselectiontoggle.cpp
<https://git.reviewboard.kde.org/r/116028/#comment36812>

    This function is never called, is it?


- Frank Reininghaus


On Feb. 24, 2014, 5:27 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116028/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 5:27 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 299328
>     http://bugs.kde.org/show_bug.cgi?id=299328
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Add a hover effect for the selection toggle.
> 
> The KItemListController handles all hover events, so we can't use the hoverMoveEvent in the KItemListWidget directly.
> Instead, if the current widget is valid, we set the widget hover position in KItemListController::hoverMoveEvent, so that the widget can react on it.
> 
> KItemListSelectionToggle has setHovered instead of hoverEnterEvent/hoverLeaveEvent now, we set the hover state in
> KItemListWidget::setHoverPosition.
> 
> The icon state toggles now between ActiveState and DisabledState (I hope these are the right states for this usecase)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontroller.cpp 7344b99 
>   dolphin/src/kitemviews/kitemlistwidget.h 954629d 
>   dolphin/src/kitemviews/kitemlistwidget.cpp 85cd70c 
>   dolphin/src/kitemviews/private/kitemlistselectiontoggle.h ba29293 
>   dolphin/src/kitemviews/private/kitemlistselectiontoggle.cpp 6bbf3c2 
> 
> Diff: https://git.reviewboard.kde.org/r/116028/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140303/42465cd3/attachment.htm>