Review Request 116469: Always go back/forward in history when pressing the corresponding mouse buttons
Commit Hook
null at kde.org
Sat Mar 1 11:19:51 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116469/#review51418
-----------------------------------------------------------
This review has been submitted with commit 7204392dcab240c59669dbf8046581bc8c49a8b9 by Frank Reininghaus to branch KDE/4.13.
- Commit Hook
On Feb. 28, 2014, 7:24 a.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116469/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2014, 7:24 a.m.)
>
>
> Review request for Dolphin, KDE Usability and Sebastian Doerner.
>
>
> Bugs: 310288
> http://bugs.kde.org/show_bug.cgi?id=310288
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Support for the backward/forward mouse buttons was added to Dolphin in https://git.reviewboard.kde.org/r/101335/ . They can be used to navigate in the history now.
>
> However, this only works if the mouse cursor is not above an item - in that case, the item is selected, and no back/forward action is triggered.
>
> Sebastian's motivation for implementing this behavior was that KDE uses "single click" activation by default, so it's not possible to select an item using a single click of the left mouse button (if the item is a file, it will also be opened, and if it's a directory, Dolphin will navigate to that directory). The backward/forward buttons can now be used to select items easily.
>
> I understand this motivation, but the behavior might be a bit counter-intuitive, and I'm not sure if the number of users who make use of the "select item using back/forward button" feature is greater than the number of users who are annoyed by this behavior (the bug report about this is https://bugs.kde.org/show_bug.cgi?id=310288 ).
>
> Moreover, we already have multiple other methods to select items with the mouse (the selection markers, Ctrl+left click, rubberband selection), so I'm not sure if this feature is really required.
>
> Therefore, I think it might make sense to change the behavior, but I don't have such a mouse at all, so I can neither test this patch, nor can I judge if my guess that the current behavior does more harm than good is correct.
>
> Testing and input from the usability team is welcome!
>
>
> Diffs
> -----
>
> dolphin/src/kitemviews/kitemlistcontroller.cpp 7344b99
> dolphin/src/views/dolphinview.cpp b68e8aa
>
> Diff: https://git.reviewboard.kde.org/r/116469/diff/
>
>
> Testing
> -------
>
> I cannot test it because I do not have a suitable mouse.
>
>
> Thanks,
>
> Frank Reininghaus
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140301/00c31ed7/attachment.htm>
More information about the kfm-devel
mailing list