Review Request 119001: Add support for high-precision touchpad scrolling

[Kai Uwe Broulik]

> On June 29, 2014, 6:49 p.m., Frank Reininghaus wrote:
> > Thanks for working on this, Kai! I can confirm that it works. This might be a stupid question, but is there a reason to change the code in the "else" branch from "event->delta()" to "event->angleDelta().y()"?

int QWheelEvent::delta() is deprecated [1] in favor of QPoint QWheelEvent::angleDelta() which supports both horizontal and vertical scrolling without the need to check orientation() and also to match QPoint QWheelEvent::pixelDelta()

[1] http://qt-project.org/doc/qt-5/qwheelevent-obsolete.html


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119001/#review61207
-----------------------------------------------------------


On June 28, 2014, 6:47 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119001/
> -----------------------------------------------------------
> 
> (Updated June 28, 2014, 6:47 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> This adds support for QWheelEvent's pixelDelta() which reports pixel-precise scrolling, mainly on touchpads. Since Qt 5.3 this is supported on X11 using XInput2, breaking Dolphin's custom scrolling on those devices.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontainer.cpp 39e6296 
> 
> Diff: https://git.reviewboard.kde.org/r/119001/diff/
> 
> 
> Testing
> -------
> 
> Tested both vertical and horizontal scrolling using both mouse and touchpad.
> 
> For some reason, although it returns a QPoint with x() and y() values, only y() is ever populated on my machine, even when doing horizontal touchpad gestures. Someone with a horizontally scrollable mousewheel might want to give this a try. I encountered this problem also in QtQuick, so might be a X11 QPA limitation.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140629/e932fd51/attachment.htm>