Review Request 119018: Do not tint the icon of the selected item in Compact and Details View, and include the icon in the selection rectangle

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119018/#review61210
-----------------------------------------------------------


+1 Yes, this change makes it look much better.
Code wise: no opinion.

- Mark Gaiser


On June 29, 2014, 6:56 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119018/
> -----------------------------------------------------------
> 
> (Updated June 29, 2014, 6:56 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 304643
>     http://bugs.kde.org/show_bug.cgi?id=304643
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> This is a modified version of Emmanuel's idea from https://git.reviewboard.kde.org/r/106827/
> 
> It removes the icon tinting for the selected item in Compact and Details View, and extends the selection rectangle such that it includes the icon area as well. The icon tinting can be disturbing, and having a selection rectangle that only includes the text can look a bit strange, especially in the Places Panel.
> 
> Ideally, we would also get rid of the tinting in Icons View, but the problem is that
> 
> 1. Highlighting only the text makes it difficult to see what the selected item is. This was the Dolphin 2.0/KDE SC 4.8 approach, see https://bugs.kde.org/show_bug.cgi?id=295515
> 
> 2. Drawing a selection rectangle around both text and icon in Icons View leads to inconsistencies with the clickable area, see https://bugs.kde.org/show_bug.cgi?id=309722#c7
> 
> 3. Having a non-rectangular area, which includes exactly the icon and the text, as shown in http://bugsfiles.kde.org/attachment.cgi?id=83419 , might cause problems with different styles, see http://lists.kde.org/?l=kfm-devel&m=140257867317630&w=2
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistwidget.h a06bb5c 
>   dolphin/src/kitemviews/kitemlistwidget.cpp c261bf1 
>   dolphin/src/kitemviews/kstandarditemlistwidget.h 4f7a913 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp e037548 
> 
> Diff: https://git.reviewboard.kde.org/r/119018/diff/
> 
> 
> Testing
> -------
> 
> Screenshots show Places Panel, Compact and Details View with default settings before/after applying this patch.
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/29/46e94473-92d3-42fc-83b8-a140c358b70e__Selection-in-Details-and-Compact-View-original.png
> Selection-in-Details-and-Compact-View-patched.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/29/d3f6cb90-3d4b-45db-8fa1-57f42194e691__Selection-in-Details-and-Compact-View-patched.png
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140629/b8f1c6ba/attachment.htm>