Review Request 119019: Remove current item highlighting in the Places Panel

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119019/#review61208
-----------------------------------------------------------


+1 for the result. Looks very good!
Code wise: no opinion since i don't know this part.

- Mark Gaiser


On June 29, 2014, 7:03 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119019/
> -----------------------------------------------------------
> 
> (Updated June 29, 2014, 7:03 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> In the Places Panel, there is always exactly one selected item, which is equal to the current item. Since the selected item is highlighted by drawing its background in a different color, it is not really necessary to highlight additionally that it is the current item.
> 
> This can be achieved by removing the calls to KItemListWidget::setCurrent(true) from KItemListView. The "current" information in the widget is only used for deciding if the "current item hightlighting", like an underline in Oxygen, should be drawn.
> 
> The motivation for this change is that I have seem some complaints about the "current item" highlighting, which can be even more distracting with non-Oxygen styles, see, e.g.,
> 
> http://forum.kde.org/viewtopic.php?f=224&t=121469
> 
> http://wheeldesign.blogspot.de/2014/06/monday-report-bi-weekly-edition.html?showComment=1402687299283#c2139876221548977296
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistview.cpp 2812588 
> 
> Diff: https://git.reviewboard.kde.org/r/119019/diff/
> 
> 
> Testing
> -------
> 
> See screenshots, which show the current master branch, the change caused by this patch, and finally, the effect of this patch and https://git.reviewboard.kde.org/r/119018/ combined.
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/29/2673149f-a272-4216-b524-6c2ef6d8c9cb__Places-Panel-current-item-original.png
> After
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/29/aff2eeeb-26b4-4cbe-bfba-f9bede68dc0c__Places-Panel-current-item-patched.png
> This patch and https://git.reviewboard.kde.org/r/119018/ combined
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/29/4fc8ddbd-403a-486c-9c5a-b5e92ce8f4c7__Places-Panel-current-item-patched-v2.png
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140629/54e8305f/attachment.htm>