Review Request 118969: DolphinTabBar (QTabBar based)

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118969/
-----------------------------------------------------------

Review request for Dolphin.


Repository: kde-baseapps


Description
-------

Implemented DolphinTabBar class to encapsulate the tab bar handling from DolphinMainWindow.

DolphinTabBar is based on QTabBar instead of KTabBar (great for frameworks 5) with
auto activation.

Currently the patch has more lines added than removed, but with DolphinTabBar + DolphinTabWidget
we can remove some more lines.

(hee no more strange slotTestCanDecode signal/slot with call by reference)


Note that this patch is completely independent from DolphinTabPage patch.


Diffs
-----

  dolphin/src/CMakeLists.txt 6e4d9f9 
  dolphin/src/dolphinmainwindow.h acf60a4 
  dolphin/src/dolphinmainwindow.cpp c60951d 
  dolphin/src/dolphintabbar.h PRE-CREATION 
  dolphin/src/dolphintabbar.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/118969/diff/


Testing
-------

Works fine so far.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140627/59fb0222/attachment.htm>