Review Request 118964: DolphinTabPage

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118964/
-----------------------------------------------------------

Review request for Dolphin.


Repository: kde-baseapps


Description
-------

Implemented DolphinTabPage class to encapsulate the split view handling from DolphinMainWindow.

The signal activeViewUrlChanged in DolphinTabPage is currently unused, but we need it later when
we implement the tab widget and tab bar.

DolphinTabPage has saveState/restoreState which are using a QByteArray instead of the KConfigGroup to
be more generic. (we can use it in the recent tabs menu in future ;)


Diffs
-----

  dolphin/src/CMakeLists.txt 6e4d9f9 
  dolphin/src/dolphinmainwindow.h acf60a4 
  dolphin/src/dolphinmainwindow.cpp c60951d 
  dolphin/src/dolphintabpage.h PRE-CREATION 
  dolphin/src/dolphintabpage.cpp PRE-CREATION 
  dolphin/src/dolphinviewcontainer.cpp 57452b9 

Diff: https://git.reviewboard.kde.org/r/118964/diff/


Testing
-------

Basic testing done.

I'll test some corner cases tonight.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140626/b1c80677/attachment.htm>