Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

[Jonathan Riddell]

> On June 23, 2014, 9:16 a.m., Raymond Wooninck wrote:
> > Hmm, now we seem to have a strange situation between KDE4 and KF5/PN.  
> > 
> > The latest version of libkonq with KDE4 is 5.14.0  (libkonq.so.5.14.0)  with libkonq.so.5 pointing to it. 
> > 
> > With this change libkonq has a lower version (4.97.0;  libkonq.so.4.97.0) with libkonq.so.5 pointing to it. 
> > 
> > This would mean that libkonq is no longer co-installable with its KDE4 version due to both using libkonq.so.5.  Given that there must have been a reason in the past to use libkonq.so.5.14.0, I would suggest to move libkonq version to 5.97.0  and use libkonq.so.6. This would ensure co-instability and consistency in version numbering.
> 
> Christoph Feck wrote:
>     Another idea is to rename the library to KF5 naming conventions. Maybe even drop the "konq" name, and use something which better describes it.

pushed a change to set it to 6.0.0


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118851/#review60757
-----------------------------------------------------------


On June 20, 2014, 8:14 p.m., Scarlett Clark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118851/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 8:14 p.m.)
> 
> 
> Review request for Dolphin, KDE Base Apps, Plasma, and Jonathan Riddell.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> I was ending up with so.SOVERSION when building this, so through some research I have come up with this patch to correct the issue.
> If there is a better way, please let me know.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a5588ea 
>   dolphin/src/CMakeLists.txt ce629fb 
>   lib/konq/CMakeLists.txt 6857e19 
> 
> Diff: https://git.reviewboard.kde.org/r/118851/diff/
> 
> 
> Testing
> -------
> 
> Builds fine on Kubuntu Utopic frameworks chroot. Results in the expected:
> libdolphinprivate.so
> libdolphinprivate.so.4.97.0
> libdolphinprivate.so.5
> libkdeinit5_dolphin.so
> libkonq.so
> libkonq.so.4.97.0
> libkonq.so.5
> 
> 
> Thanks,
> 
> Scarlett Clark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140623/9f0879a4/attachment.htm>