Review Request 118815: Fix a small TODO in KFileItemModel::setRoles(const QSet<QByteArray>& roles) and prevent that a warning message is printed

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118815/
-----------------------------------------------------------

(Updated June 19, 2014, 6:38 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Repository: kde-baseapps


Description
-------

The summary says it all - instead of emitting a signal with an empty QSet as its argument and printing a warning message, just use the roles that really have changed. The message is not really useful for users who read Dolphin's output in Konsole or .xsession-errors and can be confusing, see https://bugs.kde.org/show_bug.cgi?id=336174

In 4.13, I would prefer not to change this (even though it seems very unlikely that it causes problems), and only remove the warning output.


Diffs
-----

  dolphin/src/kitemviews/kfileitemmodel.cpp b3b926c 

Diff: https://git.reviewboard.kde.org/r/118815/diff/


Testing
-------

Unit tests work fine. Tried to switch previews on/off and added/removed columns in Details View. Everything seems to work fine.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140619/6afd27ea/attachment.htm>