Review Request 118805: DolphinRecentTabsMenu

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118805/
-----------------------------------------------------------

(Updated June 19, 2014, 12:28 a.m.)


Review request for Dolphin.


Changes
-------

Pass on two urls instead of "struct ClosedTab" in restoreClosedTab
and in rememberClosedTab.


Repository: kde-baseapps


Description
-------

Implemented DolphinRecentTabsMenu to encapsulate the recent
tabs menu related code from DolphinMainWindow in a new class.

The DolphinRecentTabsMenu remembers the tab configuration if a
tab has been closed.

Branch-Commit: 971391b270a03d9ddb90fddfbabec5cd0a8f1b5c


Diffs (updated)
-----

  dolphin/src/dolphinrecenttabsmenu.cpp PRE-CREATION 
  dolphin/src/dolphinrecenttabsmenu.h PRE-CREATION 
  dolphin/src/dolphinmainwindow.cpp 0ad224c 
  dolphin/src/dolphinmainwindow.h cb97612 
  dolphin/src/CMakeLists.txt 0a72721 

Diff: https://git.reviewboard.kde.org/r/118805/diff/


Testing
-------

Closing a tab -> appears in the recent tabs menu

Choosing a previously closed tab from recent tabs
menu an click on it -> closed tab will be opened
again and is also removed from recent tabs menu

Closing more than 8 tabs -> oldest closed tabs
will be removed (FIFO - maximum 8 entries)


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140618/28100a81/attachment.htm>