Review Request 118782: prevent goBack, goForward, goHome and goUp from being called twice
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Mon Jun 16 20:37:33 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118782/#review60210
-----------------------------------------------------------
Thanks for the patch!
I'll test it later ;)
dolphin/src/dolphinmainwindow.cpp
<https://git.reviewboard.kde.org/r/118782/#comment41947>
Remove emtpy lines between
Remove "QAction* ... =" because we don't need the pointers anymore
- Emmanuel Pescosta
On June 16, 2014, 6:40 p.m., Arjun Ak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118782/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 6:40 p.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Steps to reproduce:
> 1. Go to /home/user/foo
> 2 Go to /home/user/foo/bar
> 3. Press back/up button:
> goBack/goUp gets called twice and we end up in the home directory
> 4. Press forward button:
> goForward gets called twice and we end up in the ~/foo/bar directory
>
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.cpp 924354b
>
> Diff: https://git.reviewboard.kde.org/r/118782/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Ak
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140616/50e9c20e/attachment.htm>
More information about the kfm-devel
mailing list