[KDE Usability] Review Request 118719: Make Ctrl+I toggle the Filter Bar visibility

[Mark Gaiser]

> On June 13, 2014, 3:24 p.m., Mark Gaiser wrote:
> > You can still make a toggle of this, no?
> > 
> > The usecase would be:
> > - Not visible: ctrl + i makes it visible
> > - Visible and has focus: ctrl + i hides it
> > - Visible but not focused: ctrl + i focuses it
> 
> Thomas Pfeiffer wrote:
>     Possible, yes, but probably more confusing than helpful. Plus we would deviate from the de facto standard for no good reason. People who want to close a search or filter bar using the keyboard probably know from other applications (e.g. Firefox, Chromium, Libre Office) that it can be closed by pressign escape while it has focus anyway.
> 
> Martin Klapetek wrote:
>     Imho what Mark proposed would be nice, but I agree the Esc key must also close it if it has focus.

The ESC key should obviously stay.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118719/#review60019
-----------------------------------------------------------


On June 13, 2014, 9:17 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118719/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 9:17 a.m.)
> 
> 
> Review request for Dolphin and KDE Usability.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Users suggested in the forum thread http://forum.kde.org/viewtopic.php?f=285&t=121393 that the same shortcut should be used for showing and hiding the filter bar. This patch implements this behavior, and makes the "Show Filter Bar" action a "toggle" action to achieve that.
> 
> Ctrl+I now toggles the visibility of the filter bar, and a checkbox is added to the menu to show the current state of that action, see screenshots (the first one shows the current state, and the others the patched version with the filter bar shown/hidden). Additionally, Esc still closes the filter bar. I guess that we might want keep this behavior because some users might have got used to it, and Esc is sort of the standard key to get out of something.
> 
> A note on the implementation: I had to add the statement
> 
> emit showFilterBarChanged(true);
> 
> to the "true" branch in DolphinViewContainer::setFilterBarVisible(bool) to ensure that the state of the action is always consistent with the "visible" state of the filter bar. Without this change, it could become inconsistent in some situations. E.g., when enabling "Show Filter Bar" in the startup section of the settings dialog, the filter bar was shown, but the action was still unchecked.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h cb97612 
>   dolphin/src/dolphinmainwindow.cpp 0ad224c 
>   dolphin/src/dolphinviewcontainer.cpp 57452b9 
> 
> Diff: https://git.reviewboard.kde.org/r/118719/diff/
> 
> 
> Testing
> -------
> 
> Ctrl+I hides the filter bar if it is shown.
> 
> 
> File Attachments
> ----------------
> 
> master-filter-bar-shown.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/13/467e2831-7e90-4561-9ea3-63238a7afc27__master-filter-bar-shown.png
> patched-filter-bar-shown.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/13/f45514f7-afd1-494e-96ec-bc6c24f0c88c__patched-filter-bar-shown.png
> patched-filter-bar-hidden.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/13/9887897e-5d0a-44bf-8fa8-c04988c9cb80__patched-filter-bar-hidden.png
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140613/e8083c48/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability