Review Request 118649: Work around null return value of QApplication::clipboard()->mimeData() on Wayland

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118649/
-----------------------------------------------------------

(Updated June 11, 2014, 8:21 a.m.)


Review request for Dolphin.


Changes
-------

Thanks for your feedback! I agree that your suggestion looks better :-)

I've added "emit cutItemsChanged();" to the "early return" branch though. Just to make sure that there won't be any subtle bugs if anyone ever decides that a null return value of QApplication::clipboard()->mimeData() should mean that the clipboard is empty.


Bugs: 335053
    http://bugs.kde.org/show_bug.cgi?id=335053


Repository: kde-baseapps


Description
-------

This is a follow-up to https://git.reviewboard.kde.org/r/118450/

It seems that Qt's clipboard support is broken on Wayland - according to the bug report, the return value of QApplication::clipboard()->mimeData() on Wayland.

This patch adds safety checks to work around this problem and ensure that Dolphin does not crash on startup.

Even though only frameworks is affected AFAIK, I still think that it makes sense to have this in master as well because it simplifies the code a bit and makes "Paste into folder" work for non-file data.


Diffs (updated)
-----

  dolphin/src/dolphincontextmenu.cpp f295de7 
  dolphin/src/kitemviews/private/kfileitemclipboard.cpp faace2a 
  dolphin/src/panels/folders/treeviewcontextmenu.cpp fa8844d 

Diff: https://git.reviewboard.kde.org/r/118649/diff/


Testing
-------

I cannot test if the patch fixes the Wayland crash, but I checked that updating the "cut" state of items in the view still works, and that the "Paste" action is updated and works as expected in the context menus.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140611/ef854c3b/attachment.htm>