Review Request 118576: Make the settings dialog work in framworks

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118576/#review59364
-----------------------------------------------------------

Ship it!


Ship It!

- Emmanuel Pescosta


On June 5, 2014, 11:30 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118576/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 11:30 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 335709
>     http://bugs.kde.org/show_bug.cgi?id=335709
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> The KF5 version of KPageDialog has no virtual slot "slotButtonClicked(int button)". Its kdelibs 4.x counterpart had such a slot, which was connected automatically to the corresponding signal.
> 
> This is why the function
> 
> DolphinSettingsDialog::slotButtonClicked(int button)
> 
> is never called in frameworks, and thus, clicking the OK/Apply/Restore Defaults buttons has no effect.
> 
> 
> This can be fixed by making the functions applySettings() and restoreDefaults() functions slots, and connecting them to the "clicked" signal of the corresponding button.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/settings/dolphinsettingsdialog.h 2de1950 
>   dolphin/src/settings/dolphinsettingsdialog.cpp 8df2996 
> 
> Diff: https://git.reviewboard.kde.org/r/118576/diff/
> 
> 
> Testing
> -------
> 
> Clicking the buttons in the settings dialog works as expected for me with this patch.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140605/cf22d792/attachment.htm>