Review Request 119115: DolphinTabWidget

[Frank Reininghaus]

> On July 20, 2014, 9:45 p.m., Frank Reininghaus wrote:
> > dolphin/src/dolphintabwidget.cpp, line 39
> > <https://git.reviewboard.kde.org/r/119115/diff/3/?file=290352#file290352line39>
> >
> >     It seems that this signal does not exist either.
> 
> Emmanuel Pescosta wrote:
>     QTabWidget signal, see http://qt-project.org/doc/qt-4.8/qtabwidget.html#currentChanged

Ah, thanks for the clarification (and sorry for the stupid questions and the late response).

However, I still think that the other issues that I raised might be valid - if the changes are needed to fix a bug or improve something, then this is fine, of course, but we might also want to change it in KDE/4.14 then.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119115/#review62752
-----------------------------------------------------------


On July 15, 2014, 9:26 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119115/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 9:26 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Implemented DolphinTabWidget class to encapsulate the tab handling from DolphinMainWindow.
> 
> Removed the method for text squeezing because the QTabBar can do this automatically.
> 
> The tab sizes are different, any idea how to fix this?
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt 7b0210a 
>   dolphin/src/dolphinmainwindow.h 9c7f185 
>   dolphin/src/dolphinmainwindow.cpp 41bd626 
>   dolphin/src/dolphintabwidget.h PRE-CREATION 
>   dolphin/src/dolphintabwidget.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119115/diff/
> 
> 
> Testing
> -------
> 
> Works great so far.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140730/c5a35e4c/attachment.htm>