Review Request 119399: Dont show context menu when dragging and dropping onto read only folders in the places menu

[Arjun Ak]

> On July 28, 2014, 10:30 p.m., Frank Reininghaus wrote:
> > Thanks for the updated patch and sorry for the late reply. I was away for most of last week and still haven't finished reading all incoming mails yet.
> > 
> > I'm a bit unsure if showing the error message in the status bar is the best solution. A better solution might be to simply show a "Drop forbidden" mouse cursor while hovering read-only items, such that the drop would not be possible at all.
> > 
> > However, finding out if a device is read-only or not will require mounting the device first, but we do not want to mount a device simply by hovering it, I think - this would be unwanted in many situations, and it might freeze the GUI if mounting takes some time.
> > 
> > Maybe we should show the "drop forbidden" cursor if we can find out about the read-only state quickly, and only show the error message if that is not the case? Maybe I have to think about some more, but any ideas from you and others are welcome as well, of course.
> > 
> > You might also want to add David Faure as a reviewer beccause he is responsible for lib/konq.

I too don't think mounting the partition on hover is a good idea. Not only would it be slow, it might also require authentication. Password window popping up just because you accidently hovered on an item in the panel would be really annoying.


- Arjun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119399/#review63343
-----------------------------------------------------------


On July 29, 2014, 12:57 p.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119399/
> -----------------------------------------------------------
> 
> (Updated July 29, 2014, 12:57 p.m.)
> 
> 
> Review request for Dolphin and David Faure.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> ^
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp d321d3b 
>   dolphin/src/panels/places/placespanel.h 16112e8 
>   dolphin/src/panels/places/placespanel.cpp f19fa1e 
>   dolphin/src/views/draganddrophelper.cpp f8ae0ad 
> 
> Diff: https://git.reviewboard.kde.org/r/119399/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140729/04bd9f0f/attachment.htm>