Review Request 118782: prevent goBack, goForward, goHome and goUp from being called twice

[Frank Reininghaus]

> On June 16, 2014, 7:37 p.m., Emmanuel Pescosta wrote:
> > dolphin/src/dolphinmainwindow.cpp, lines 1604-1611
> > <https://git.reviewboard.kde.org/r/118782/diff/1/?file=281736#file281736line1604>
> >
> >     Remove emtpy lines between
> >     
> >     Remove "QAction* ... =" because we don't need the pointers anymore
> 
> Frank Reininghaus wrote:
>     Agreed :-)
>     
>     FWIW, the reason why the duplicate connections exist at all is that there used to be two "triggered" signals in the KDE SC 4.x era, one of which was used to indicate that the action was triggered with a different mouse button, or with keyboard modifiers, such as Shift, pressed.
>     
>     Unfortunately, support for middle-clicking toolbar buttons and other such things seems to be gone in KF5. In principle, we could also remove the slots that have the Qt::MouseButtons arguments. However, I would prefer if we could find a way to re-enable this functionality. I assume that there are quite a few users who liked it :-(
> 
> Emmanuel Pescosta wrote:
>     > I would prefer if we could find a way to re-enable this functionality.
>     +1 from my side!
> 
> Arjun Ak wrote:
>     >middle-clicking toolbar buttons
>     What does that do?
> 
> Emmanuel Pescosta wrote:
>     > What does that do?
>     E.g. When you click onto the home button with the middle-mouse-button, the home directory will be opened in a new tab instead of loading the home directory in the current view.
> 
> Arjun Ak wrote:
>     Wouldn't you have to subclass QMenu for that?

In KDE SC 4.x, this was solved by adding a new signal to the KAction class, which inherits QAction, and ensuring in KToolBar that this signal is emitted if a button is middle-clicked.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118782/#review60210
-----------------------------------------------------------


On June 25, 2014, 1:40 p.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118782/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 1:40 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Steps to reproduce:
> 1. Go to /home/user/foo
> 2  Go to /home/user/foo/bar
> 3. Press back/up button:
>     goBack/goUp gets called twice and we end up in the home directory
> 4. Press forward button:
>     goForward gets called twice and we end up in the ~/foo/bar directory
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 924354b 
> 
> Diff: https://git.reviewboard.kde.org/r/118782/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140728/f90b0619/attachment.htm>