Review Request 119428: Port Dolphin accessibility to Qt 5

[Frederik Gladhorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119428/
-----------------------------------------------------------

(Updated July 26, 2014, 11:54 a.m.)


Review request for Dolphin, Frank Reininghaus, Sebastian Sauer, and Jeremy Whiting.


Repository: kde-baseapps


Description
-------

Port the accessibility implementation for the custom list views to Qt 5. Lose 90 lines of code on the way :)


Diffs
-----

  dolphin/src/kitemviews/kitemlistviewaccessible.cpp d9ddd58 
  dolphin/src/CMakeLists.txt cc358a2 
  dolphin/src/kitemviews/kitemlistview.cpp d35dd89 
  dolphin/src/kitemviews/kitemlistviewaccessible.h c2213cd 

Diff: https://git.reviewboard.kde.org/r/119428/diff/


Testing
-------

Ran dolphin a few times. It works nicely with Orca.
Make sure to run "gsettings set org.gnome.desktop.a11y.applications screen-reader-enabled true" once before testing, then Orca should just work and read Dolphin :)
All the tedious setup from Qt 4 is gone and the code quite a bit cleaner all in all.


Thanks,

Frederik Gladhorn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140726/54ef46c6/attachment.htm>