Review Request 119399: Dont show context menu when dragging and dropping onto read only folders in the places menu

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119399/#review62884
-----------------------------------------------------------


Thanks for the patch! I agree that not showing the "Move/Copy/Link" menu when dropping items on a read-only entry in the Places Panel makes sense (because selecting any action in the menu triggers an error message in a message box, which must be clicked away).

However, I think that we should not use the KMessageWidget for this kind of non-critical error messages. In the past years, we got quite a bit of feedback from users who considered the message widget annoying (e.g., when showing the "Folder cannot be dropped on itself" message). It's different for critical messages (like "Cannot enter directory xyz") though.

- Frank Reininghaus


On July 22, 2014, 10:51 a.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119399/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 10:51 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> ^
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/draganddrophelper.cpp f8ae0ad 
> 
> Diff: https://git.reviewboard.kde.org/r/119399/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140722/930a07ed/attachment.htm>