Review Request 119238: Fix the visibility of the "Places Selector" in the location bar

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119238/
-----------------------------------------------------------

(Updated July 16, 2014, 7:15 a.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Bugs: 337389
    http://bugs.kde.org/show_bug.cgi?id=337389


Repository: kde-baseapps


Description
-------

The "Places Selector" at the front of the location bar should be shown if and only if the Places Panel is hidden.

Since https://git.reviewboard.kde.org/r/118964/, there are two problems with this functionality:

1. In new tabs, the expected visibility of the selector is reversed.

2. When splitting the view, the selector is always shown in the new view.

This patch fixes both problems.


Diffs
-----

  dolphin/src/dolphinmainwindow.cpp 0c48928 
  dolphin/src/dolphintabpage.cpp c8e4263 

Diff: https://git.reviewboard.kde.org/r/119238/diff/


Testing
-------

I cannot reproduce the problems any more, and I have not found any new problems yet so far.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140716/b021b2f5/attachment.htm>