Review Request 119115: DolphinTabWidget

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119115/
-----------------------------------------------------------

(Updated July 15, 2014, 11:26 p.m.)


Review request for Dolphin.


Changes
-------

Fixed all mentioned problems

Renamed openNewTab() slot to openNewActivatedTab() in DolphinTabWidget and in DolphinMainWindow so that the method name reflects the behaviour of this method.


Repository: kde-baseapps


Description
-------

Implemented DolphinTabWidget class to encapsulate the tab handling from DolphinMainWindow.

Removed the method for text squeezing because the QTabBar can do this automatically.

The tab sizes are different, any idea how to fix this?


Diffs (updated)
-----

  dolphin/src/CMakeLists.txt 7b0210a 
  dolphin/src/dolphinmainwindow.h 9c7f185 
  dolphin/src/dolphinmainwindow.cpp 41bd626 
  dolphin/src/dolphintabwidget.h PRE-CREATION 
  dolphin/src/dolphintabwidget.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119115/diff/


Testing
-------

Works great so far.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140715/2d03c47a/attachment.htm>