Review Request 118966: Avoid opening unused tabs which are closed again after startup has finished (when directory/file urls are given)

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118966/#review61750
-----------------------------------------------------------

Ship it!


Thanks for the patch and sorry for not responding earlier. This is a really good idea, please go ahead and push it.

- Frank Reininghaus


On June 26, 2014, 10:09 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118966/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 10:09 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Instead of always opening a new tab with the home url and closing it again when directory/file urls are passed on, 
> we now use the given directories/files directly to open new tabs on startup.
> 
> Makes the code easier and we can reuse openDirectories/openFiles in future (if needed).
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinapplication.cpp 8e83a85 
>   dolphin/src/dolphinmainwindow.cpp c60951d 
> 
> Diff: https://git.reviewboard.kde.org/r/118966/diff/
> 
> 
> Testing
> -------
> 
> Works fine.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140706/723db6c6/attachment.htm>