Review Request 118969: DolphinTabBar (QTabBar based)

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118969/
-----------------------------------------------------------

(Updated July 4, 2014, 5:51 p.m.)


Review request for Dolphin.


Changes
-------

Adjusted this patch (clean apply) because DolphinTabPage is in master now.


Repository: kde-baseapps


Description
-------

Implemented DolphinTabBar class to encapsulate the tab bar handling from DolphinMainWindow.

DolphinTabBar is based on QTabBar instead of KTabBar (great for frameworks 5) with
auto activation.

Currently the patch has more lines added than removed, but with DolphinTabBar + DolphinTabWidget
we can remove some more lines.

(hee no more strange slotTestCanDecode signal/slot with call by reference)


Note that this patch is completely independent from DolphinTabPage patch.


Diffs (updated)
-----

  dolphin/src/CMakeLists.txt 518c8b7 
  dolphin/src/dolphinmainwindow.h 7c3bff4 
  dolphin/src/dolphinmainwindow.cpp d9fe645 
  dolphin/src/dolphintabbar.h PRE-CREATION 
  dolphin/src/dolphintabbar.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/118969/diff/


Testing
-------

Works fine so far.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140704/c76a2548/attachment.htm>