Review Request 118964: DolphinTabPage

[Emmanuel Pescosta]

> On July 4, 2014, 12:39 a.m., Frank Reininghaus wrote:
> > Thanks for the update. Very nice work! It's great to see the DolphinMainWindow monster reduced by more than 200 lines :-)
> > 
> > BTW, did you use QPointers for m_*ViewContainer just because this initializes the pointer to 0 automatically, or is there another reason? I'm just curious.

Yep, initialization with 0 and 0 on delete (hmm, maybe I suffer from a smart-pointer addiction and so I try to avoid raw pointers in C++(<11) code as much as possible?! ;)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118964/#review61580
-----------------------------------------------------------


On July 4, 2014, 5:44 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118964/
> -----------------------------------------------------------
> 
> (Updated July 4, 2014, 5:44 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Implemented DolphinTabPage class to encapsulate the split view handling from DolphinMainWindow.
> 
> The signal activeViewUrlChanged in DolphinTabPage is currently unused, but we need it later when
> we implement the tab widget and tab bar.
> 
> DolphinTabPage has saveState/restoreState which are using a QByteArray instead of the KConfigGroup to
> be more generic. (we can use it in the recent tabs menu in future ;)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt 6e4d9f9 
>   dolphin/src/dolphinmainwindow.h acf60a4 
>   dolphin/src/dolphinmainwindow.cpp c60951d 
>   dolphin/src/dolphintabpage.h PRE-CREATION 
>   dolphin/src/dolphintabpage.cpp PRE-CREATION 
>   dolphin/src/dolphinviewcontainer.cpp 57452b9 
> 
> Diff: https://git.reviewboard.kde.org/r/118964/diff/
> 
> 
> Testing
> -------
> 
> Basic testing done.
> 
> I'll test some corner cases tonight.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140704/fab7bcb9/attachment.htm>