Review Request 115410: Don't store the index of the file item in the VersionControlObserver::ItemState

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115410/
-----------------------------------------------------------

(Updated Jan. 31, 2014, 7:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Repository: kde-baseapps


Description
-------

One of many changes to make the version control code more robust.
Found this problem while I was trying to reproduce bug 330605.

Don't store the index of the file item in the VersionControlObserver::ItemState, get the index of the file item on demand instead.

Fixes some "old"-index (model has changed) problems, esp. when you copy/move around files while the version control thread is still running.


Diffs
-----

  dolphin/src/views/versioncontrol/versioncontrolobserver.h 980374a 
  dolphin/src/views/versioncontrol/versioncontrolobserver.cpp 888d934 

Diff: https://git.reviewboard.kde.org/r/115410/diff/


Testing
-------

Moved around some bigger folders. (Tested with the Dropbox-Plugin)

Version states were always correct ;)


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140131/7a9000c9/attachment.htm>