Review Request 115405: Always enable the "Create New..." menu if the URL is writable (workaround for problems with kioslaves that do not provide a "root item")

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115405/#review48653
-----------------------------------------------------------

Ship it!


Thanks for the patch! :)

Tested with some read-only/writable local folders, works nice.

I can't test it with samba/paragon-ntfs, but I think we can trust Alex in this case ;)

- Emmanuel Pescosta


On Jan. 30, 2014, 7:33 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115405/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 7:33 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 330001 and 330015
>     http://bugs.kde.org/show_bug.cgi?id=330001
>     http://bugs.kde.org/show_bug.cgi?id=330015
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> To find out if the current URL is writable or not, we wait for the KDirLister's completed() signal and then investigate its rootItem() via KFileItemListProperties.
> 
> This goes wrong if there is no "rootItem", which could be caused by a problem in the kioslave, see http://lists.kde.org/?l=kfm-devel&m=139015381308473&w=2
> 
> We got quite a few reports about smb since 4.12.0 (that might indicate that something broke in kio_smb recently) and also one report which does not seem to involve smb.
> 
> I propose to fix this problem by creating a KFileItem for the current URL and using that if we don't get a rootItem() from the dir lister. This is also the approach that Konqueror's context menu uses, BTW. It is my understanding though that the rootItem() approach can prevent that the GUI is blocked if the access to the URL is very slow because the access happens in the kioslave (an external process).
> 
> A real fix for the problem in the affected kioslaves might be better, but since we don't know if this will break again in other kioslaves in the future, I think that the workaround makes sense.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp 303731c 
> 
> Diff: https://git.reviewboard.kde.org/r/115405/diff/
> 
> 
> Testing
> -------
> 
> The "Create New..." menu is still enabled and disabled approprately for me, as before. A user who suffers from the bug tested the patch and confirmed that it fixes the problem for him.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140130/c2dc57e8/attachment.htm>